From 32e0b45255ab7e5564c933beefc702746ab385db Mon Sep 17 00:00:00 2001 From: Yuxuan Shui Date: Wed, 31 Oct 2018 23:18:10 +0000 Subject: [PATCH] Sanitize opacity data get from window props Signed-off-by: Yuxuan Shui --- src/win.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/win.c b/src/win.c index 6ba9fd6..c2d23d2 100644 --- a/src/win.c +++ b/src/win.c @@ -271,7 +271,12 @@ bool wid_get_opacity_prop(session_t *ps, Window wid, opacity_t def, winprop_t prop = wid_get_prop(ps, wid, ps->atom_opacity, 1L, XCB_ATOM_CARDINAL, 32); if (prop.nitems) { - *out = *prop.data.p32; + // sanitize the opacity data, if opacity is out of bounds, + // assuming they are opaque + if (*prop.data.p32 < 0 || *prop.data.p32 > OPAQUE) + *out = OPAQUE; + else + *out = *prop.data.p32; ret = true; }